virajjasani commented on PR #1844: URL: https://github.com/apache/phoenix/pull/1844#issuecomment-2278842132
1. Update the description on Javadocs and PR/Jira to specify Salt bucket case 2. Pass null non-pk column set and if it is not null, add values from KeyValueColumnExpression 3. Loggers with view name and more details if required e.g. for sibling views, if the columns don't match, log the column set for view and sibling view, and also sibling view name 4. Tests with comments on what criteria is covered -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
