rejeb commented on PR #145:
URL:
https://github.com/apache/phoenix-connectors/pull/145#issuecomment-2402097690
I added tests for datasource v1 when I've been working on PHOENIX-6783
because there has been no tests before that.
I did that by duplicating all tests in `PhoenixSparkIT` and changed the
.format("phoenix") to .format("org.apache.phoenix.spark").
Now both .format() uses datasource V2 implementation so all these tests are
duplication and will just exercice same code 2 times. IMO, there is no need to
keep them because all ests exists in `PhoenixSparkIT`.
I kept a some tests to valide thatthe use of
.format("org.apache.phoenix.spark") works.
For deprecated methods `phoenixTableAsDataFrame`, `phoenixTableAsRDD` and
`saveToPhoenix` I added some test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
