virajjasani commented on PR #2008: URL: https://github.com/apache/phoenix/pull/2008#issuecomment-2475338299
> @virajjasani The changes look functionally correct but I didn't like how we are creating a specialized path in the code just for this use case. I would like it better if we can implement it in a much cleaner way without creating so many if/else's. Maybe @kadirozde has some ideas. I agree that having separate path is making it difficult to comprehend but when i looked at how things are implemented for this path, i didn't feel we could do much because this path of server side delete is all about scanner performing delete at server side and then returning count of rows deleted. This itself looks a bit hacky to me in the first place. One single attribute determining whether the region scanner is supposed to not just scan but also delete the row. Besides, i also thought of making the client not use client aggregator class (because this new use case does not return count of deleted rows) but then realized that maintaining old client <-> new server compatibility will be affected if we do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
