stoty commented on code in PR #2085:
URL: https://github.com/apache/phoenix/pull/2085#discussion_r1972003411


##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java:
##########
@@ -493,11 +493,7 @@ protected void handleKerberosAndLogin() throws 
SQLException {
                                 LOGGER.info("Trying to connect to a secure 
cluster as {} "
                                         + "with keytab {}",
                                     principal, keytab);
-                                final Configuration newConfig = 
getConfiguration(principal, keytab);
-                                // We are intentionally changing the passed in 
Configuration object
-                                
UserGroupInformation.setConfiguration(newConfig);

Review Comment:
   The added the possibility to configure the Hadoop UserGroupInformation from 
the connection URL / info objects.
   
   That doesn't look like a good idea, but it is technically an incompatible 
change.
   
   It is also a JVM global config, which makes it extra scary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to