NihalJain commented on PR #2023: URL: https://github.com/apache/phoenix/pull/2023#issuecomment-2761083102
> Can you check that the spotless rules are consistent with https://phoenix.apache.org/develop.html ? Yes they are same as in the site. ``` <eclipse> <file>${session.executionRootDirectory}/dev/PhoenixCodeTemplate.xml</file> </eclipse> <importOrder> <file>${session.executionRootDirectory}/dev/phoenix.importorder</file> </importOrder> ``` > We can just update the rules if we want to stick to the HBase conventions. Looking at the import order definition of hbase, it seems more specific to hbase: **HBase import order:** ``` 3=org.apache.hadoop.hbase.shaded 2=org.apache.hbase.thirdparty 1= 0=\# ``` Sample: ``` package org.apache.hadoop.hbase.client; import static org.junit.Assert.assertEquals; import java.net.URL; import javax.servlet.Filter; import org.apache.hadoop.HadoopIllegalArgumentException; import org.apache.yetus.audience.InterfaceStability; import org.slf4j.Logger; import org.apache.hbase.thirdparty.com.google.common.base.Preconditions; import org.apache.hadoop.hbase.shaded.protobuf.generated.BackupProtos; ``` **Phoenix import order:** ``` 4=system 3=com 2=org 1=javax 0=java ``` Sample: ``` package org.apache.hadoop.hbase.client; import static org.junit.Assert.assertEquals; import java.net.URL; import javax.servlet.ServletException; import org.apache.hadoop.HadoopIllegalArgumentException; import org.apache.yetus.audience.InterfaceStability; import org.slf4j.Logger; import org.apache.hbase.thirdparty.com.google.common.base.Preconditions; import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos; import com.google.protobuf.ByteString; ``` Phoenix import order organizes imports based on general package hierarchies and system imports. May be this is better? Or we could do following to be similar to hbase? ``` 3=org.apache.hadoop.phoenix.shaded 2=org.apache.phoenix.thirdparty 1= 0=\# ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
