virajjasani commented on code in PR #2154: URL: https://github.com/apache/phoenix/pull/2154#discussion_r2093508276
########## phoenix-core-client/src/main/java/org/apache/phoenix/util/MutationUtil.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.util; + +import java.io.IOException; +import java.util.List; +import java.util.Map; + +import org.apache.hadoop.hbase.Cell; +import org.apache.hadoop.hbase.CellUtil; +import org.apache.hadoop.hbase.client.Put; + +public class MutationUtil { + + /** + * Creates a true deep copy of the Put Mutation, including deep copies of all cells if the + * cells are backed by off-heap. The Mutation(Mutation source) constructor always does a + * shallow copy of the cells. + * @param original The original Put Mutation to copy + * @return A new Put Mutation with deep copies of all fields and Cells + */ + public static Put copyPut(Put original) throws IOException { + // Copies the bytes internally + Put copy = new Put(original.getRow()); + + // Copy the fields in Mutation class + // Copy timestamp + copy.setTimestamp(original.getTimestamp()); + // Copy durability + copy.setDurability(original.getDurability()); Review Comment: I wonder why hbase does not copy these fields in their clone constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
