[
https://issues.apache.org/jira/browse/PHOENIX-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954068#comment-17954068
]
ASF GitHub Bot commented on PHOENIX-7407:
-----------------------------------------
rejeb commented on PR #145:
URL:
https://github.com/apache/phoenix-connectors/pull/145#issuecomment-2909241939
> Regarding the savemode changes: How do other Spark SQL connectors handle
Append/Overwrite ? Do you think that accepting both is a good practice ?
Many connectors handle both Append/Overwrite. The issue here is that the
Overwrite mode have'nt been implement respecting Spark definition for this mode.
In order to not breakup old application that still use V1, the behavior of
Overwrite cannot be changed.
Other option will be to remove it, but it will require small change for old
applications to update their code and Append instead of Overwrite.
> Remove deprecated datasource V1 code from spark2 and spark3 connector
> ---------------------------------------------------------------------
>
> Key: PHOENIX-7407
> URL: https://issues.apache.org/jira/browse/PHOENIX-7407
> Project: Phoenix
> Issue Type: Improvement
> Reporter: rejeb ben rejeb
> Assignee: rejeb ben rejeb
> Priority: Major
>
> The pupose of this jira is to remove deprecated datasource V1 code. It is
> safe to remove these classes since they are used internally by spark and not
> referenced directly in applications code.
> But in order to not impact old applications, all V1 interfaces (utlity
> methods and the source type "org.apache.phoenix.spark") will be kept and code
> will modified to use new connector version classes.
> As dfiscussed on dev mailing list, one acceptable side effect is that spark3
> SameMode will accept both "Append" and "Overwrite" values. However behavior
> will be the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
