rejeb commented on PR #145: URL: https://github.com/apache/phoenix-connectors/pull/145#issuecomment-2915993835
> > It should truncate table and then insert data. > > IMO, we should not change actual behavior because it might cause data loss for apps still using the old version and unaware of this change. > > Thanks. That's definitely not something we want the connector to do. Can we log something at INFO when truncate is specified ? Yes, we can log something at INF., In this PR, I kept the actual behavior for Overwrite it means that it will not do the truncate before inserting data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
