NihalJain commented on PR #2024: URL: https://github.com/apache/phoenix/pull/2024#issuecomment-3086675273
> @NihalJain what is the diff b/ this PR and #2120? #2120 which is nothing but #2024 and #2119 applied one after another. I had raised #2120 only to check if spotless check work after this patch is applied. May be we don't need it anymore as it anyways fails to apply patch. We can merge this one first and check if #2119 is not causing failure before we merge that. Basically #2119 enforces spotless on every build, this PR just reformats entire codebase. Also I have run build and 'mvn clean verify' with this PR locally: there were 2 errors and 7 failures but not anything I think would be related to this change. Also we need to rebase again once we are ready to merge, any commit to codebase causes conflict here as this patch touches almost all files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
