[
https://issues.apache.org/jira/browse/PHOENIX-6851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011575#comment-18011575
]
Nihal Jain commented on PHOENIX-6851:
-------------------------------------
Hi I have put up PRs for PHOENIX-7675, PHOENIX-7676 and PHOENIX-7443.
Will raise PR for PHOENIX-7442 once PHOENIX-7675, PHOENIX-7676 are merged.
PHOENIX-7443 should be merged at last.
|| ||JIRA||master||5.2||5.1||
|1|PHOENIX-7441| ✅
[22054c2|https://github.com/apache/phoenix/commit/22054c24932804744e0f4916cc614b2a81c65667]|
✅
[c7063dd|https://github.com/apache/phoenix/commit/c7063dddac5efab0624a62cff62ef8478bb5b3cd]|
✅
[48364cf|https://github.com/apache/phoenix/commit/48364cf14b9bac28df91673dc8eb6f8445728322]|
|2|PHOENIX-7675| ✅
[571d458|https://github.com/apache/phoenix/commit/571d45844a4eac2914e8bda8269bc5aab1ebb665]
[{{67d47a6}}|https://github.com/apache/phoenix/commit/67d47a612e745cf7f21a8522eb92209c4c43784f]
|[#2256|https://github.com/apache/phoenix/pull/2256]|[#2257|https://github.com/apache/phoenix/pull/2257]|
|3|PHOENIX-7676| ✅
[{{861010d}}|https://github.com/apache/phoenix/commit/861010d5cf8d18930a948c7c5dd1cc7be994a975]|[#2258|https://github.com/apache/phoenix/pull/2258]|[#2259|https://github.com/apache/phoenix/pull/2259]|
|4|PHOENIX-7442| ✅
[67d47a6|https://github.com/apache/phoenix/commit/67d47a612e745cf7f21a8522eb92209c4c43784f]|
❌| ❌|
|5|PHOENIX-7443| ✅
[{{f305a5c}}|https://github.com/apache/phoenix/commit/f305a5c532d8e7693b7f14361d7b54a346a77ce6]|[#2260|https://github.com/apache/phoenix/pull/2260]|[#2261|https://github.com/apache/phoenix/pull/2261]|
CC: [~stoty], [~vjasani]
> Use spotless to format code in phoenix
> --------------------------------------
>
> Key: PHOENIX-6851
> URL: https://issues.apache.org/jira/browse/PHOENIX-6851
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Aman Poonia
> Assignee: Nihal Jain
> Priority: Major
> Fix For: 5.3.0
>
>
> Similar to what Apache HBase does today, we want to similarly use spotless
> plugin to format code in Apache Phoenix.
> The goal is to improve code consistency across the project and make it easier
> for new contributors to onboard as today it is very difficult for new
> contributors (even exitsing one's) to ensure code is properly formatted
> across the repository in a consistent manner.
> Hence to overcome this hindrance, here is a summary of the proposed plan
> based on recent discussions and past experiences:
> # Integrate the Spotless plugin and update the code template
> ** Integrate the Spotless plugin into the Phoenix project. This will allow
> us to standardize code formatting through Maven, reducing reliance on
> IDE-specific formatting rules.
> ** Update the development template (dev/PhoenixCodeTemplate.xml) to sync the
> formatting standards used in HBase.
> ** Align the license header with the one used by HBase for consistency. 2)
> Apply Spotless to reformat the entire codebase:
> # Apply the Spotless plugin to reformat the entire codebase
> ** This will be done in a single commit to minimize noise in future patches.
> ** No manual changes should be made in this PR, for ease of review
> # Add Spotless to the pre-commit checks
> ** Integrate Spotless checks into the pre-commit process to ensure code
> consistency moving forward.
> ** Build is supposed to fail if code does not meet spotless rules
> ** We may want to add this step only after the initial reformatting is
> complete to avoid build failures and ease of backport to other branches.
> Hence we plan to create 3 separate JIRA sub-tasks to handle each of above
> mentioned steps independently and repeat for all active branches i.e 5.1, 5.2
> and master.
> We should merge this to 5.x only after 5.2.1 is released.
> See [https://lists.apache.org/thread/9gbh5xs544h4q4w4xt64oy9osy8g8f81] for
> complete discussion on this issue.
> CC: [~stoty], [~mnpoonia], [~larsfrancke]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
