haridsv commented on code in PR #2226:
URL: https://github.com/apache/phoenix/pull/2226#discussion_r2255816615
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKey2IT.java:
##########
@@ -591,8 +598,8 @@ private static void
validateReturnedRowBeforeUpsert(Connection conn, String upse
updateCount = resultPair.getFirst();
resultSet = resultPair.getSecond();
}
- boolean isOnDuplicateKey = upsertSql.toUpperCase().contains("ON DUPLICATE
KEY");
- if (conn.getAutoCommit() && isOnDuplicateKey) {
+ boolean isReturningRow = upsertSql.toUpperCase().contains("RETURNING *");
Review Comment:
Right now `ON DUPLICATE KEY` alone is expected to return a row unless
`RETURNING *` is specified, in fact that is the very reason we introduced this
new syntax, to avoid performance overhead when the user is not really
interested to fetch the row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
