palashc commented on code in PR #2252:
URL: https://github.com/apache/phoenix/pull/2252#discussion_r2278115491


##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServices.java:
##########
@@ -627,6 +627,10 @@ public interface QueryServices extends SQLCloseable {
   String PHOENIX_CDC_STREAM_PARTITION_EXPIRY_MIN_AGE_MS =
     "phoenix.cdc.stream.partition.expiry.min.age.ms";
 
+  String PHOENIX_UNCOVERED_INDEX_MAX_POOL_SIZE = 
"phoenix.uncovered.index.threads.max";
+  String PHOENIX_UNCOVERED_INDEX_KEEP_ALIVE_TIME_MS =
+    "phoenix.uncovered.index.threads.keepalive.ms";

Review Comment:
   done



##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##########
@@ -501,6 +501,9 @@ public class QueryServicesOptions {
   public static final long 
DEFAULT_PHOENIX_CDC_STREAM_PARTITION_EXPIRY_MIN_AGE_MS =
     30 * 60 * 60 * 1000; // 30 hours
 
+  public static final int DEFAULT_PHOENIX_UNCOVERED_INDEX_MAX_POOL_SIZE = 512;
+  public static final int DEFAULT_PHOENIX_UNCOVERED_INDEX_KEEP_ALIVE_TIME_MS = 
60 * 1000; // 1min

Review Comment:
   good catch, done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to