meszinorbi commented on code in PR #202:
URL: https://github.com/apache/phoenix-omid/pull/202#discussion_r2358946310
##########
common/src/main/proto/TSOProto.proto:
##########
@@ -16,51 +16,52 @@
// limitations under the License.
//
+syntax = "proto3";
option java_package = "org.apache.omid.proto";
option optimize_for = SPEED;
message Request {
- optional TimestampRequest timestampRequest = 1;
- optional CommitRequest commitRequest = 2;
- optional HandshakeRequest handshakeRequest = 3;
- optional FenceRequest fenceRequest = 4;
+ TimestampRequest timestampRequest = 1;
+ CommitRequest commitRequest = 2;
+ HandshakeRequest handshakeRequest = 3;
+ FenceRequest fenceRequest = 4;
}
message TimestampRequest {
}
message CommitRequest {
- optional int64 startTimestamp = 1;
- optional bool isRetry = 2 [default = false];
+ int64 startTimestamp = 1;
+ bool isRetry = 2;
repeated int64 cellId = 3;
repeated int64 TableId = 4;
}
message FenceRequest {
- optional int64 TableId = 1;
+ int64 TableId = 1;
}
message Response {
- optional TimestampResponse timestampResponse = 1;
- optional CommitResponse commitResponse = 2;
- optional HandshakeResponse handshakeResponse = 3;
- optional FenceResponse fenceResponse = 4;
+ TimestampResponse timestampResponse = 1;
+ CommitResponse commitResponse = 2;
+ HandshakeResponse handshakeResponse = 3;
+ FenceResponse fenceResponse = 4;
}
message TimestampResponse {
- optional int64 startTimestamp = 1;
+ int64 startTimestamp = 1;
}
message FenceResponse {
- optional int64 TableId = 1;
- optional int64 FenceId = 2;
+ int64 TableId = 1;
+ int64 FenceId = 2;
}
message CommitResponse {
- optional bool aborted = 1;
- optional int64 startTimestamp = 2;
- optional int64 commitTimestamp = 3;
+ bool aborted = 1;
Review Comment:
When I modified the proto file, I misread the changes resulting in this
wrong decision. I'll revert these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
