sanjeet006py commented on code in PR #2291:
URL: https://github.com/apache/phoenix/pull/2291#discussion_r2556562494


##########
pom.xml:
##########
@@ -54,6 +55,12 @@
     <module>phoenix-pherf</module>
     <module>phoenix-tracing-webapp</module>
     <!-- shaded artifact and assembly modules are added in shade-and-assembly 
profile -->
+    <module>phoenix-client-parent</module>
+    <module>phoenix-client-parent/phoenix-client-embedded</module>
+    <module>phoenix-client-parent/phoenix-client-lite</module>
+    <module>phoenix-server</module>
+    <module>phoenix-mapreduce-byo-shaded-hbase</module>
+    <module>phoenix-assembly</module>

Review Comment:
   Actually, I am seeing Javadoc failure for after patch is applied saying 
above extra modules listed under `shade-and-assembly` profile for `hbase-2.6` 
are not found. I thought adding them here might help me get past that but 
doesn't seem to be case. So, reverting this change. I will be posting a summary 
of unexpected failures I am seeing and would need help on that. Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to