NihalJain commented on code in PR #2399:
URL: https://github.com/apache/phoenix/pull/2399#discussion_r3044430651
##########
phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/FormatToBytesWritableMapper.java:
##########
@@ -163,7 +163,7 @@ protected void map(LongWritable key, Text value, Context
context)
RECORD record = null;
try {
record = getLineParser().parse(value.toString());
- } catch (IOException e) {
+ } catch (IOException | RuntimeException e) {
Review Comment:
We can improve, this was a hack in commons-csv-1.0
https://github.com/apache/commons-csv/blob/4ef853bc13d3548ce9cae02c7c26ddbc1c790669/src/main/java/org/apache/commons/csv/CSVParser.java#L398
We could upgrade to newer one, where there is better error management!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
