jpisaac commented on code in PR #2400: URL: https://github.com/apache/phoenix/pull/2400#discussion_r3118161596
########## phoenix-core-client/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java: ########## Review Comment: We should have checks for same tenant creating multiple views without where clauses. It should not be allowed. ########## phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantTTLIT.java: ########## @@ -0,0 +1,520 @@ +/* Review Comment: @palashc Looks good. Maybe add a few more test cases - - tables with indexes, - view with same names and diff orgs ########## phoenix-core-client/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java: ########## Review Comment: Should have a test with PHOENIX_UPDATABLE_VIEW_RESTRICTION_ENABLED set to true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
