kadirozde commented on code in PR #2428: URL: https://github.com/apache/phoenix/pull/2428#discussion_r3192336330
########## phoenix-core-client/src/main/java/org/apache/phoenix/compile/keyspace/ExpressionNormalizer.java: ########## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.compile.keyspace; + +import java.sql.SQLException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; + +import org.apache.hadoop.hbase.CompareOperator; +import org.apache.hadoop.hbase.io.ImmutableBytesWritable; +import org.apache.phoenix.expression.AndExpression; +import org.apache.phoenix.expression.ComparisonExpression; +import org.apache.phoenix.expression.Expression; +import org.apache.phoenix.expression.InListExpression; +import org.apache.phoenix.expression.OrExpression; +import org.apache.phoenix.expression.RowValueConstructorExpression; + +/** + * Rewrites a WHERE {@link Expression} into the canonical AND/OR form the v2 key-space model + * operates on. Two rewrites are applied bottom-up: + * <ul> + * <li><b>RVC inequality</b>: {@code (c1,...,cK) OP (v1,...,vK)} for OP in + * {@code <, ≤, >, ≥} expands to the lexicographic OR of ANDs. Example: + * {@code (c1,c2,c3) > (v1,v2,v3)} becomes + * {@code (c1>v1) OR (c1=v1 AND c2>v2) OR (c1=v1 AND c2=v2 AND c3>v3)}. Equality is already + * expanded upstream by {@link ComparisonExpression#create}.</li> + * <li><b>IN list on a scalar</b>: {@code a IN (v1,...,vK)} expands to + * {@code a=v1 OR ... OR a=vK}. IN with an RVC LHS is left intact; the visitor handles + * that shape directly by producing one KeySpace per row value.</li> + * </ul> Review Comment: Corrected the java doc in 9a50c3419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
