Copilot commented on code in PR #2500: URL: https://github.com/apache/phoenix/pull/2500#discussion_r3789337864
########## phoenix-hbase-compat-2.6.6/pom.xml: ########## @@ -0,0 +1,116 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.phoenix</groupId> + <artifactId>phoenix</artifactId> + <version>5.4.0-SNAPSHOT</version> + </parent> + + <artifactId>phoenix-hbase-compat-2.6.6</artifactId> + <name>Phoenix Hbase 2.6.6 compatibility</name> + <description>Compatibility module for HBase 2.6.6+</description> + + <properties> + <!-- + TODO(PHOENIX-7873): HBase 2.6.6 is not yet GA on Maven Central. This compat module is + built against a locally-installed 2.6.6-SNAPSHOT until then. At GA: flip this value to + 2.6.6-hadoop3 in lockstep with <hbase-2.6.runtime.version> in the root pom.xml, then + remove both TODO comments. Find them with: grep -rn 'TODO(PHOENIX-7873)'. + --> + <hbase26.compat.version>2.6.6-SNAPSHOT</hbase26.compat.version> Review Comment: This unpublished SNAPSHOT makes the PR unbuildable in a clean checkout: this compat module is listed unconditionally in the root reactor, so even the default HBase 2.5 build must resolve `2.6.6-SNAPSHOT`. The current HBase release list still ends the 2.6 line at 2.6.5. Before merge, update this property and the root runtime property together to the published 2.6.6 Hadoop 3 artifact; otherwise CI and users without a locally installed HBase build will fail dependency resolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
