Copilot commented on code in PR #2535:
URL: https://github.com/apache/phoenix/pull/2535#discussion_r3789334316
##########
phoenix-client-parent/pom.xml:
##########
@@ -80,6 +80,7 @@
<exclude>META-INF/*.RSA</exclude>
<exclude>META-INF/license/*</exclude>
<exclude>META-INF/NOTICE</exclude>
+
<exclude>META-INF/services/java.net.spi.InetAddressResolverProvider</exclude>
Review Comment:
This exclusion is inside the `*:*` filter, so it removes this SPI descriptor
from every shaded artifact rather than only from dnsjava as intended. That can
silently discard another dependency's resolver provider despite the service
transformer below. Scope the exclusion to `dnsjava:dnsjava` with a dedicated
filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
