lfrancke commented on code in PR #2586:
URL: https://github.com/apache/phoenix/pull/2586#discussion_r3791353896
##########
phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1503,7 +1511,7 @@ private void sendMutations(Iterator<Entry<TableInfo,
List<Mutation>>> mutationsI
// create a span per target table
// TODO maybe we can be smarter about the table name to string here?
Span child =
- Tracing.child(span, "Writing mutation batch for table: " +
Bytes.toString(htableName));
+ PhoenixTracing.createSpan("phoenix.mutation.batch.write." +
Bytes.toString(htableName));
Review Comment:
Yup, good catch. This should be fixed now.
We didn't use the suggested `finally` because there is already a `finally`
which runs on every retry iteration. Ending it there would kill the just
created span immediately.
##########
pom.xml:
##########
@@ -1799,6 +1794,31 @@
<bannedImport>com.sun.istack.**</bannedImport>
</bannedImports>
</RestrictImports>
+ <RestrictImports>
+ <includeTestCode>true</includeTestCode>
+ <reason>HTrace is removed, use OpenTelemetry via
PhoenixTracing</reason>
+ <bannedImports>
+ <bannedImport>org.apache.htrace.**</bannedImport>
+ </bannedImports>
+ </RestrictImports>
+ </rules>
+ </configuration>
+ </execution>
+ <execution>
+ <id>banned-illegal-dependencies</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <phase>validate</phase>
+ <configuration>
+ <rules>
+ <bannedDependencies>
+ <message>HTrace is retired, use OpenTelemetry via
PhoenixTracing</message>
+ <searchTransitive>true</searchTransitive>
+ <excludes>
+ <exclude>org.apache.htrace:*</exclude>
+ </excludes>
Review Comment:
Yep, that was my fault. I did not realize that Hadoop 3.2.4 still has
HTrace. I've now changed the rule to only look for direct dependencies we add
ourselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
