apurtell commented on PR #2428: URL: https://github.com/apache/phoenix/pull/2428#issuecomment-5703759254
Thanks @kadirozde . All of the Copilot inline threads from the latest review round are resolved. I checked out the PR head commit and confirmed default is opt-in. Verified each Copilot finding against the patch. Executed a sample of unit tests, all green: WhereOptimizerTest, WhereCompilerTest, QueryOptimizerTest, and the full compile.keyspace.** package. I do see WhereOptimizerTest.testWithLargeORs fails. It looks like the test wasn't updated after the change pushed up to the PR on Sep 2. I will address this before merging if there are not more issues. /cc @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
