eric-maynard commented on code in PR #344:
URL: https://github.com/apache/polaris/pull/344#discussion_r1792197594
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/FileStorageConfigurationInfo.java:
##########
@@ -42,7 +43,8 @@ public String getFileIoImplClassName() {
@Override
public void validatePrefixForStorageType(String loc) {
- if (!loc.startsWith(getStorageType().getPrefix())
+ if (getStorageType().getPrefixes().stream()
Review Comment:
> For this use case here it seems we could push down a method in StorageType
like isPathValidForStorageType where we pass in the
loc.toLowerCase(Locale.ROOT) here or just pass in loc and the StorageType
itself can hold this logic.
This is my preference; for AzureLocation we already have a method like
`isAzurePath` but since we aren't actually implementing `AwsLocation` etc. here
I didn't want to add that to the `StorageLocation` interface if unnecessary.
For now, I'll hardcode the path into that test but let me add a comment to
track the above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
