MonkeyCanCode opened a new pull request, #409:
URL: https://github.com/apache/polaris/pull/409

   # Description
   
   As https://github.com/apache/polaris/pull/387 add a helm unit test to the CI 
pipeline for deployment manifest. This PR add the unit test for the remaining 
six manifests. This had being discussed in 
https://github.com/apache/polaris/pull/386 with @adutra.
   
   ## Type of change
   
   Please delete options that are not relevant.
   
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Documentation update
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] This change requires a documentation update
   
   # How Has This Been Tested?
   
   
   ```sh
   xxxx@DESKTOP:~/k8s/polaris(helm_unit_test)$ helm unittest helm/polaris/ 2>&1 
| grep -v 'symbolic link'
   
   ### Chart [ polaris ] helm/polaris/
   
    PASS   helm/polaris/tests/configmap_test.yaml
    PASS   helm/polaris/tests/deployment_test.yaml
    PASS   helm/polaris/tests/hpa_test.yaml
    PASS   helm/polaris/tests/ingress_test.yaml
    PASS   helm/polaris/tests/job_test.yaml
    PASS   helm/polaris/tests/service_test.yaml
    PASS   helm/polaris/tests/serviceaccount_test.yaml
   
   Charts:      1 passed, 1 total
   Test Suites: 7 passed, 7 total
   Tests:       151 passed, 151 total
   Snapshot:    0 passed, 0 total
   Time:        399.43489ms
   ```
   
   # Checklist:
   
   Please delete options that are not relevant.
   
   - [x] I have performed a self-review of my code
   - [x] I have commented my code, particularly in hard-to-understand areas
   - [ ] I have made corresponding changes to the documentation
   - [x] My changes generate no new warnings
   - [x] If adding new functionality, I have discussed my implementation with 
the community using the linked GitHub issue
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to