eric-maynard commented on code in PR #414:
URL: https://github.com/apache/polaris/pull/414#discussion_r1824808276
##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:
##########
@@ -834,7 +834,10 @@ public LoadTableResponse loadTableWithAccessDelegation(
callContext.getPolarisCallContext(),
catalogEntity,
PolarisConfiguration.ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING)) {
- throw new ForbiddenException("Access Delegation is not supported for
this catalog");
+ throw new ForbiddenException(
+ "Access Delegation is not enabled for this catalog. Please consult
applicable "
+ + "documentation for the catalog config property '%s' to enable
this feature",
+
PolarisConfiguration.ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING.catalogConfig());
Review Comment:
The message is a little unclear; you can set the catalog property but you
can also set the featureConfig. I also don't know if we need to say "please
consult applicable documentation ..." rather than just saying e.g. "to enable
this, set X or Y"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
