lrichards-etsy commented on code in PR #408:
URL: https://github.com/apache/polaris/pull/408#discussion_r1826403273
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java:
##########
@@ -91,6 +91,24 @@ public long expireAfterRead(
});
}
+ /** How long credentials should remain in the cache. */
+ private static long maxCacheDurationMs() {
+ var cacheDurationSeconds =
+ PolarisConfiguration.loadConfig(
+ PolarisConfiguration.STORAGE_CREDENTIAL_CACHE_DURATION_SECONDS);
+ var credentialDurationSeconds =
+
PolarisConfiguration.loadConfig(PolarisConfiguration.STORAGE_CREDENTIAL_DURATION_SECONDS);
+ if (cacheDurationSeconds <= credentialDurationSeconds) {
Review Comment:
I think this is flipped? It should throw the error if cache > credential
duration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
