danielhumanmod commented on code in PR #312:
URL: https://github.com/apache/polaris/pull/312#discussion_r1828748240
##########
polaris-service/src/test/java/org/apache/polaris/service/task/TableCleanupTaskHandlerTest.java:
##########
@@ -76,7 +79,13 @@ public void testTableCleanup() throws IOException {
TestSnapshot snapshot =
TaskTestUtils.newSnapshot(fileIO, "manifestList.avro", 1,
snapshotId, 99L, manifestFile);
String metadataFile = "v1-49494949.metadata.json";
- TaskTestUtils.writeTableMetadata(fileIO, metadataFile, snapshot);
Review Comment:
1. Cleanup of a single metadata file with a single snapshot
##########
polaris-service/src/test/java/org/apache/polaris/service/task/TableCleanupTaskHandlerTest.java:
##########
@@ -303,7 +323,20 @@ public void testTableCleanupMultipleSnapshots() throws
IOException {
manifestFile1,
manifestFile3); // exclude manifest2 from the new snapshot
String metadataFile = "v1-295495059.metadata.json";
- TaskTestUtils.writeTableMetadata(fileIO, metadataFile, snapshot,
snapshot2);
Review Comment:
2. Cleanup of a single metadata file across multiple snapshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
