flyrain commented on code in PR #442:
URL: https://github.com/apache/polaris/pull/442#discussion_r1842756769
##########
polaris-service/src/test/java/org/apache/polaris/service/PolarisApplicationIntegrationTest.java:
##########
@@ -341,7 +341,7 @@ public void testIcebergListNamespacesNestedNotFound()
throws IOException {
sessionCatalog.listNamespaces(
sessionContext, Namespace.of("top_level", "whoops")))
.isInstanceOf(NoSuchNamespaceException.class)
- .hasMessage("Namespace does not exist: top_level.whoops");
+ .hasMessage("Namespace does not exist: top_level%1Fwhoops");
Review Comment:
This is interesting, as Iceberg still uses dot to join different level of
namespaces,
https://github.com/apache/iceberg/blob/09634857e4a1333f5dc742d1dca3921e9a9f62dd/api/src/main/java/org/apache/iceberg/catalog/Namespace.java#L97-L97.
In this case, `Namespace.of("top_level", "whoops")` should be referred to
`top_level.whoops`, unless the rest util somehow squash two levels together
with the "%1F".
@singhpk234 , could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
