eric-maynard commented on code in PR #478:
URL: https://github.com/apache/polaris/pull/478#discussion_r1857159307
##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -266,9 +266,9 @@ public void initialize(String name, Map<String, String>
properties) {
CatalogProperties.FILE_IO_IMPL);
}
}
- this.closeableGroup = CallContext.getCurrentContext().closeables();
- closeableGroup.addCloseable(metricsReporter());
Review Comment:
Sorry, I think that was my confusion. It looks like there are some objects
in the CloseableGroup (the value of`metricReporter()`) that are no longer going
in there. I just wanted to double-check where they are getting closed now. Does
putting `this` in the `CloseableGroup` somehow still do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
