collado-mike commented on code in PR #465:
URL: https://github.com/apache/polaris/pull/465#discussion_r1867106780
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisResolvedPathWrapper.java:
##########
@@ -19,62 +19,41 @@
package org.apache.polaris.core.persistence;
import java.util.List;
-import java.util.stream.Collectors;
import org.apache.polaris.core.entity.PolarisEntity;
/**
* Holds fully-resolved path of PolarisEntities representing the targetEntity
with all its grants
* and grant records.
*/
public class PolarisResolvedPathWrapper {
- private final List<ResolvedPolarisEntity> resolvedPath;
+ private final List<PolarisEntity> resolvedPath;
Review Comment:
This sounds fine to me - the main thing for me is to remove the different
entity types so that each interface is dealing directly with the entity types
(albeit, with a convenience wrapper in this case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
