eric-maynard commented on code in PR #505:
URL: https://github.com/apache/polaris/pull/505#discussion_r1868974635
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##########
@@ -93,6 +93,9 @@ public boolean isChildOf(StorageLocation potentialParent) {
} else {
String slashTerminatedLocation = ensureTrailingSlash(this.location);
String slashTerminatedParentLocation =
ensureTrailingSlash(potentialParent.location);
+ if (slashTerminatedLocation.startsWith("/") &&
slashTerminatedParentLocation.startsWith("file:///")) {
+ slashTerminatedLocation = "file://" + slashTerminatedLocation;
Review Comment:
+1, it should definitely be `file:///` not `file://`.
However the `:///` is [not part of the
scheme](https://datatracker.ietf.org/doc/rfc8089/) so that specific constant
might be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
