adutra commented on code in PR #558:
URL: https://github.com/apache/polaris/pull/558#discussion_r1885899864
##########
service/common/src/main/java/org/apache/polaris/service/context/DefaultCallContextResolver.java:
##########
@@ -67,16 +62,6 @@ public CallContext resolveCallContext(
.addKeyValue("queryParams", queryParams)
.addKeyValue("headers", headers)
.log("Resolving CallContext");
- final Map<String, String> parsedProperties =
parseBearerTokenAsKvPairs(headers);
-
- if (!parsedProperties.containsKey(PRINCIPAL_PROPERTY_KEY)) {
- LOGGER.warn(
- "Failed to parse {} from headers ({}); using {}",
- PRINCIPAL_PROPERTY_KEY,
- headers,
- PRINCIPAL_PROPERTY_DEFAULT_VALUE);
- parsedProperties.put(PRINCIPAL_PROPERTY_KEY,
PRINCIPAL_PROPERTY_DEFAULT_VALUE);
Review Comment:
This is dead code. The parsedProperties variable is discarded when the
method returns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
