dimas-b commented on code in PR #465:
URL: https://github.com/apache/polaris/pull/465#discussion_r1890997366
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java:
##########
@@ -460,10 +462,13 @@ public class PolarisAuthorizerImpl implements
PolarisAuthorizer {
}
private final PolarisConfigurationStore featureConfig;
+ private final Provider<PolarisGrantManager> grantManagerFactory;
@Inject
- public PolarisAuthorizerImpl(PolarisConfigurationStore featureConfig) {
+ public PolarisAuthorizerImpl(
+ PolarisConfigurationStore featureConfig, Provider<PolarisGrantManager>
grantManagerFactory) {
Review Comment:
`PolarisAuthorizerImpl` is a light-weight object. Does it hurt to make it
request-scoped? Cross-scope references resolved at call time are indeed to be
avoided, but, IMHO, the `Provider` falls into the same category.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
