adutra commented on code in PR #587:
URL: https://github.com/apache/polaris/pull/587#discussion_r1897824466
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -122,6 +123,21 @@ public void setRegion(@Nullable String region) {
this.region = region;
}
+ public String getAwsAccountId() {
Review Comment:
```suggestion
@JsonIgnore public String getAwsAccountId() {
```
(since this is a derived property)
##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/admin/PolarisServiceImplIntegrationTest.java:
##########
@@ -939,11 +939,16 @@ public void testCreateListUpdateAndDeleteCatalog() {
.startsWith("Cannot modify");
}
+ // Allow update of fields that are support (e.g. new default-base-location
and role ARN when AWS
Review Comment:
```suggestion
// Allow update of fields that are supported (e.g. new
default-base-location and role ARN when AWS
```
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -122,6 +123,21 @@ public void setRegion(@Nullable String region) {
this.region = region;
}
+ public String getAwsAccountId() {
+ return parseAwsAccountId(roleARN);
+ }
+
+ private String parseAwsAccountId(String arn) {
Review Comment:
`parseAwsAccountId` and `validateArn` should be static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
