adutra commented on PR #573: URL: https://github.com/apache/polaris/pull/573#issuecomment-2562515446
@flyrain and @chenjian2664 I don't mind adding these annotations, but if we think globally about Polaris code, and assuming that, since the API is biased towards non-nullability by default, about 80% of method arguments and method return types are non-null, annotating each and every one of them will quickly become a visual clutter. Instead, there are better options to mark an API as "non-null by default", e.g. using JSR 305 annotation `@ParametersAreNonnullByDefault` placed at package level. Most IDEs are capable of understanding that and would automatically enforce non-nullability everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
