flyrain commented on code in PR #469:
URL: https://github.com/apache/polaris/pull/469#discussion_r1913985432
##########
polaris-core/src/main/java/org/apache/polaris/core/context/CallContext.java:
##########
@@ -100,8 +100,9 @@ public Map<String, Object> contextVariables() {
* CallContext}.
*/
static CallContext copyOf(CallContext base) {
- RealmContext realmContext = base.getRealmContext();
- PolarisCallContext polarisCallContext = base.getPolarisCallContext();
+ String realmId = base.getRealmContext().getRealmIdentifier();
+ RealmContext realmContext = () -> realmId;
+ PolarisCallContext polarisCallContext =
PolarisCallContext.copyOf(base.getPolarisCallContext());
Review Comment:
Nit: there are new comments in the caller, could we also add comments here
to explain why we need cloned objects `realmContext` and `polarisCallContext`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
