flyrain commented on code in PR #741:
URL: https://github.com/apache/polaris/pull/741#discussion_r1915722165
##########
polaris-core/src/main/java/org/apache/polaris/core/context/RealmId.java:
##########
@@ -18,17 +18,26 @@
*/
package org.apache.polaris.core.context;
+import com.fasterxml.jackson.annotation.JsonValue;
+import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import com.fasterxml.jackson.databind.annotation.JsonSerialize;
+import org.apache.polaris.immutables.PolarisImmutable;
+import org.immutables.value.Value;
+
/**
- * Represents the elements of a REST request associated with routing to
independent and isolated
- * "universes". This may include properties such as region, deployment
environment (e.g. dev, qa,
- * prod), and/or account.
+ * Represents the ID of the realm used in a REST request associated with
routing to independent and
+ * isolated "universes".
*/
-public interface RealmContext {
+@PolarisImmutable
+@JsonSerialize(as = ImmutableRealmId.class)
+@JsonDeserialize(as = ImmutableRealmId.class)
+public interface RealmId {
Review Comment:
If we were making this change, why don't we call it `Realm`, instead of
`RealmId`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
