snazy commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1916053548
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1627,6 +1627,12 @@ private FileIO refreshIOWithCredentials(
// the credentials should always override table-level properties, since
// storage configuration will be found at whatever entity defines it
tableProperties.putAll(credentialsMap);
+
+ // Populate the internal properties to FileIO in case the FileIO
implementation needs them
+ Map<String, String> internalProperties =
+
storageInfoEntity.map(PolarisEntity::getInternalPropertiesAsMap).orElse(Map.of());
Review Comment:
Maybe bikeshedding, but there is no "Polaris FileIO" - it's running code
from a different project, that can change at any time.
IMHO the issue is rather to have properly typed configurations rather than
two generic property bags, where everything can end in. Sure, property bags are
easy to start with - but in my experience always cause issues later on - and
it's nearly impossible to fix that "later".
It looks that this change is meant to deal with credentials, which should
IMHO be handled with a lot of care.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
