collado-mike commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1917474699
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1627,6 +1627,12 @@ private FileIO refreshIOWithCredentials(
// the credentials should always override table-level properties, since
// storage configuration will be found at whatever entity defines it
tableProperties.putAll(credentialsMap);
+
+ // Populate the internal properties to FileIO in case the FileIO
implementation needs them
+ Map<String, String> internalProperties =
+
storageInfoEntity.map(PolarisEntity::getInternalPropertiesAsMap).orElse(Map.of());
Review Comment:
Passing in the entire set of table internal properties definitely seems
wrong to me. For example, in the case of federated catalog items, one can
imagine some api key or password to access a remote Iceberg catalog might be
found in internal properties. I wouldn't want to pass that to the `FileIO` with
the assumption that it's simply going to ignore what it doesn't understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
