adutra commented on code in PR #610:
URL: https://github.com/apache/polaris/pull/610#discussion_r1919007163
##########
quarkus/admin/build.gradle.kts:
##########
@@ -35,6 +35,7 @@ dependencies {
implementation(project(":polaris-api-iceberg-service"))
implementation(project(":polaris-service-common"))
implementation(project(":polaris-quarkus-service"))
+ runtimeOnly(project(":polaris-eclipselink"))
Review Comment:
I know it's a bit of a paradigm shift, but we get used to it quickly: adding
dependencies at run time is not possible with frameworks like Quarkus. They
must be added at build time instead.
We won't include all possible JDBC drivers, but we can (and should) include
the most popular ones (if their licenses are compatible). I think Postgres is
by far the one that should definitely be included. But we can include many
others if there is reasonable ask for that from the community. Nessie ships
with something like 8 drivers, and that's fine. But if someone wants to use
Polaris (or Nessie) against a driver that is not present by default – say,
Oracle – then they need to rebuild the application themselves and include the
extra dependencies in their own build.
Hope that's a bit more clear now :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
