dimas-b commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1924524612
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -19,9 +19,21 @@
package org.apache.polaris.service.catalog.io;
import java.util.Map;
+import java.util.Set;
+import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.io.FileIO;
+import org.apache.polaris.core.persistence.PolarisResolvedPathWrapper;
+import org.apache.polaris.core.storage.PolarisStorageActions;
/** Interface for providing a way to construct FileIO objects, such as for
reading/writing S3. */
public interface FileIOFactory {
FileIO loadFileIO(String impl, Map<String, String> properties);
Review Comment:
As for me, the new `loadFileIO` API and the default impl is quite
reasonable. Let's clean this PR up and open it for general review :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
