snazy commented on code in PR #840:
URL: https://github.com/apache/polaris/pull/840#discussion_r1925290290
##########
.asf.yaml:
##########
@@ -38,11 +38,15 @@ github:
protected_branches:
main:
required_pull_request_reviews:
+ # if we want to use this, GitHub CODEOWNERS should be cleanly define,
with different patterns/owners
require_code_owner_reviews: false
required_approving_review_count: 1
required_linear_history: true
+ # requires all conversations to be resolved before merging
+ required_conversation_resolution: true
Review Comment:
TBH, I'd prefer a "soft rule".
Comments, on code line or not, can contain useful information for later -
for example referenced in issues or elsewhere or just left on the PR for
reference.
"Resolving" with this flag would mean that the commenter resolves this,
which might not happen "just in time", although the issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
