dimas-b commented on code in PR #886:
URL: https://github.com/apache/polaris/pull/886#discussion_r1930731263
##########
quarkus/service/build.gradle.kts:
##########
@@ -165,6 +165,8 @@ tasks.named<Test>("intTest").configure {
// Same issue as above: allow a java security manager after Java 21
// (this setting is for the application under test, while the setting above
is for test code).
systemProperty("quarkus.test.arg-line", "-Djava.security.manager=allow")
+ // force the locale, just in case the user is having another default locale
+ systemProperty("quarkus.default-locale", "en_US")
Review Comment:
i18n is extra work. I do not think merely changing the server's default
locale is enough. For instance, given an error do we want to render it in one
locale in the server log and in another locale for the REST/HTTP response (the
client's locale)?
From my POV, if we allow custom locales we should forbid
`String.toUpper/LowerCase()` in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
