dimas-b commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1930868160
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java:
##########
@@ -18,10 +18,50 @@
*/
package org.apache.polaris.service.catalog.io;
+import jakarta.annotation.Nonnull;
+import jakarta.enterprise.context.ApplicationScoped;
import java.util.Map;
+import java.util.Set;
+import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.io.FileIO;
+import org.apache.polaris.core.context.RealmId;
+import org.apache.polaris.core.persistence.PolarisResolvedPathWrapper;
+import org.apache.polaris.core.storage.PolarisStorageActions;
-/** Interface for providing a way to construct FileIO objects, such as for
reading/writing S3. */
+/**
+ * Interface for providing a way to construct FileIO objects, such as for
reading/writing S3.
+ *
+ * <p>Implementations are available via CDI as {@link ApplicationScoped
@ApplicationScoped} beans.
Review Comment:
I'm fine to keep this comment :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
