snazy commented on code in PR #884: URL: https://github.com/apache/polaris/pull/884#discussion_r1930948175
########## CONTRIBUTING.md: ########## @@ -100,3 +99,12 @@ The Apache Polaris build currently requires Java 21 or later. There are a few to * [SDKMAN!](https://sdkman.io/) follow the installation instructions, then run `sdk list java` to see the available distributions and versions, then run `sdk install java <identifer from list>` using the identifier for the distribution and version (>= 21) of your choice. * [jenv](https://www.jenv.be/) If on a Mac you can use jenv to set the appropriate SDK. +## Good Practices + +* Change of public interface (or more generally speaking Polaris extension point) should be discussed and approved on the dev mailing list. + The discussion on the dev mailing list should happen before having a "ready-for-review" Pull Request. +* `git log` you can help you find the original/relevant authors of the code you are modifying. If you need, feel free to tag the author in your Pull Request comment if you need assistance or review. Review Comment: Other than this: +1 on this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
