dimas-b commented on code in PR #848:
URL: https://github.com/apache/polaris/pull/848#discussion_r1930969924
##########
service/common/src/main/java/org/apache/polaris/service/context/RealmContextConfiguration.java:
##########
@@ -33,6 +33,16 @@ public interface RealmContextConfiguration {
/** The header name that contains the realm identifier. */
String headerName();
+ /**
+ * Whether to require the realm header to be present in the request. If this
is true and the realm
+ * header is not present, the request will be rejected. If this is false and
the realm header is
+ * not present, the default realm will be used.
+ *
+ * <p>Note: this is actually only enforced when using {@link
DefaultRealmIdResolver}. When using
+ * {@link TestRealmIdResolver}, this setting is ignored.
+ */
+ boolean requireHeader();
Review Comment:
Defaulting to `true` would be a behaviour change at the REST/HTTP level. I'd
prefer to keep old behaviour in this PR and change defaults later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
