dimas-b commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1934216769
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -2039,8 +1975,7 @@ private List<TableIdentifier>
listTableLike(PolarisEntitySubType subType, Namesp
* @return FileIO object
*/
private FileIO loadFileIO(String ioImpl, Map<String, String> properties) {
- Map<String, String> propertiesWithS3CustomizedClientFactory = new
HashMap<>(properties);
- return fileIOFactory.loadFileIO(ioImpl,
propertiesWithS3CustomizedClientFactory);
+ return CatalogUtil.loadFileIO(ioImpl, properties, new Configuration());
Review Comment:
The current state of this PR looks acceptable to me. I still this we should
avoid the call to `CatalogUtil.loadFileIO(...)` in `BasePolarisCatalog` and
always use the factory. Ideally, we should not have test-specific logic in
production code, such as that controlled by the
`INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST` property in
`BasePolarisCatalog`... but that can be done later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
