flyrain commented on code in PR #907:
URL: https://github.com/apache/polaris/pull/907#discussion_r1934741136


##########
site/content/in-dev/unreleased/metastores.md:
##########
@@ -49,6 +49,8 @@ The `configuration-file` option must point to an [EclipseLink 
configuration file
 `persistence.xml`, is used to set up the database connection properties, which 
can differ depending
 on the type of database and its configuration.
 
+> Note: EclipseLink is scanning the folder containing the `persistence.xml` 
but also the parent folder. For this reason, you have to locate the 
`persistence.xml` at least two folders down to the root folder, e.g. 
`/deployments/config/persistence.xml` is correct, whereas 
`/deployments/persistence.xml` is not correct.
+

Review Comment:
   > EclipseLink is scanning the folder containing the `persistence.xml` but 
also the parent folder.
   
   is this really the reason why it goes to infinity loop? We'd better not 
mention it if we are not sure.
   
   ```suggestion
   > Note: You have to locate the `persistence.xml` at least two folders down 
to the root folder, e.g. `/deployments/config/persistence.xml` is OK, whereas 
`/deployments/persistence.xml` will cause an infinity loop.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to