adutra commented on code in PR #589:
URL: https://github.com/apache/polaris/pull/589#discussion_r1935899864
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -101,25 +100,6 @@ public PolarisConfiguration<T> build() {
}
}
- /**
- * Returns the value of a `PolarisConfiguration`, or the default if it
cannot be loaded. This
- * method does not need to be used when a `CallContext` is already available
- */
- public static <T> T loadConfig(PolarisConfiguration<T> configuration) {
Review Comment:
Indeed, the `realmId` parameter is nullable since not every call site has
access to that. Without it, we always fetch the default config without
considering any realm overrides.
But anyways this is going to be reverted, so I don't see the point of
keeping the discussion going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
