MonkeyCanCode commented on code in PR #881:
URL: https://github.com/apache/polaris/pull/881#discussion_r1936410334
##########
regtests/client/python/cli/command/catalogs.py:
##########
@@ -212,4 +215,3 @@ def execute(self, api: PolarisDefaultApi) -> None:
api.update_catalog(self.catalog_name, request)
else:
raise Exception(f'{self.catalogs_subcommand} is not supported in
the CLI')
-
Review Comment:
@eric-maynard updated:
```
(polaris-venv) ➜ test git:(cli_aws_region) ✗ pytest test_cli_parsing.py
==========================================================================
test session starts
===========================================================================
platform darwin -- Python 3.13.0, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/yong/Desktop/GitHome/polaris/regtests/client/python
configfile: pyproject.toml
collected 6 items
test_cli_parsing.py ......
```
Btw, these test cases never ran and many of them are empty. Not sure if
this is by designed or should people start adding test cases to them and update
regtest script to run those as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]