dimas-b commented on code in PR #953:
URL: https://github.com/apache/polaris/pull/953#discussion_r1944970284
##########
site/content/in-dev/unreleased/rest-catalog-open-api.md:
##########
@@ -17,11 +17,11 @@
# specific language governing permissions and limitations
# under the License.
#
-title: 'Apache Iceberg OpenAPI'
-linkTitle: 'Iceberg OpenAPI'
+title: 'Apache Polaris and Iceberg Catalog OpenAPI'
Review Comment:
nit: "OpenAPI" is a standard for defining APIs. It is not an API that
Polaris implements: Proposal: `Polaris API specification`.
We can mention following OpenAPI guidelines and including the Iceberg REST
API in the description of the spec.
##########
spec/polaris-catalog-apis/notifications-api.yaml:
##########
@@ -68,7 +68,7 @@ paths:
content:
application/json:
schema:
- $ref:
'../rest-catalog-open-api.yaml#/components/responses/IcebergErrorResponse'
+ $ref:
'../rest-catalog-open-api.yaml#/components/schemas/IcebergErrorResponse'
Review Comment:
Would you mind making actual API spec changes in a separate PR? This PR's
title indicates it's a "doc" change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
